Fix bug with KeyError: 'params/eta'
#1246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
changed the title
KeyError: 'params/eta'
|
Any follow up on this please? The PR looks ready. |
thinkall
reviewed
Mar 15, 2024
Comment on lines
+30
to
+32
| Args: | ||
| d (dict): The target dictionary to be updated. | ||
| u (dict): A dictionary containing values to be merged into `d`. |
There was a problem hiding this comment.
Suggested change
| Args: | |
| d (dict): The target dictionary to be updated. | |
| u (dict): A dictionary containing values to be merged into `d`. | |
| Update the dictionary `d` with the dictionary `u` recursively. | |
| Args: | |
| d (dict): The target dictionary to be updated. | |
| u (dict): A dictionary containing values to be merged into `d`. | |
| Example: | |
| ```python | |
| d= {'num_boost_round': 10, 'params': {'max_depth': 12, 'eta': 0.02}} | |
| u= {'params': {'verbosity': 3, 'booster': 'gbtree'}} | |
| recursive_update(d, u) | |
| d # {'num_boost_round': 10, 'params': {'max_depth': 12, 'eta': 0.02, 'verbosity': 3, 'booster': 'gbtree'}} | |
| ``` |
thinkall
requested changes
Mar 15, 2024
There was a problem hiding this comment.
Check out here for code formatting. https://microsoft.github.io/FLAML/docs/Contribute#pre-commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Reference to #1244
Related issue number
#1244
Checks